Running some tests with HSC data, Eric noticed that I was a bit loose with some of the common parameter names in a few estimation stages, e.g. column_names in Inform_KNearNeigh been the equivalent of bands in most of the other estimators, we should make these more standard for a v1 RAIL release. There is infrastructure for propagating this info across multiple stages/estimators already implemented via the rail.core.common_params option SHARED_PARAMS, so we might want to switch the estimators to use SHARED_PARAMS and set this in just one place.
eacharles
commented
1 year ago
Running some tests with HSC data, Eric noticed that I was a bit loose with some of the common parameter names in a few estimation stages, e.g.
column_namesin Inform_KNearNeigh been the equivalent ofbandsin most of the other estimators, we should make these more standard for a v1 RAIL release. There is infrastructure for propagating this info across multiple stages/estimators already implemented via therail.core.common_paramsoptionSHARED_PARAMS, so we might want to switch the estimators to useSHARED_PARAMSand set this in just one place.