LSSTDESC / rail_attic

Redshift Assessment Infrastructure Layers
MIT License
14 stars 9 forks source link

Issue/359/dsps v3.0.0 #366

Closed torluca closed 1 year ago

eacharles commented 1 year ago

I pulled in the changes from main, so that there aren't conflicts anymore.

But we probably want to figure out something else to do about the files in src/rail/examples_data/creation_data/data/dsps_default_data it looks like those are 59 MB, which seems really big for a code repo.

We have some examples use setting up examples to curl data from NERSC, we could do that here.

I guess the filter files are pretty small, but src/rail/examples_data/creation_data/data/dsps_default_data/ssp_data_fsps_v3.2_lgmet_age.h5 is about 58 MB.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (83d002a) 100.00% compared to head (cab3aec) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #366 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 40 40 Lines 2860 2860 ========================================= Hits 2860 2860 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

torluca commented 1 year ago

Hi @eacharles , I followed your suggestions and implemented the following changes: