search

LSSTDESC / rail_attic

Redshift Assessment Infrastructure Layers
MIT License
14 stars 9 forks source link

Issue/355/cleanups #368

Closed OliviaLynn closed 1 year ago

OliviaLynn commented 1 year ago

For LSSTDESC/rail_hub#25, some very simple tidying.

After a talk with Alex, we decided it was better to go ahead and remove the goldenspike yaml, because the fixed paths they include can present difficulties, we already have a working example of reading in a yam pipeline file (Run_Pipe.ipynb), and running the goldenspike notebook will create a reusable pipeline file that works with the user's environment.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9aba738) 100.00% compared to head (181f09c) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main LSSTDESC/RAIL#368 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 38 38 Lines 2588 2588 ========================================= Hits 2588 2588 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

eacharles commented 1 year ago

I'd like to proposed a different solution to the paths in the goldenspike notebook.yaml, which is to set the paths relative to $RAILDIR and to os os.path.expandvars in the rail/core/data.py functions that open files. I think that is a better solution long term

OliviaLynn commented 1 year ago

I'd like to proposed a different solution to the paths in the goldenspike notebook.yaml, which is to set the paths relative to $RAILDIR and to os os.path.expandvars in the rail/core/data.py functions that open files. I think that is a better solution long term

Heard--I have a new PR open to address the pipeline file and get it functioning again, please let me know what you think.

I chose to set the yaml paths so they'll work if the user calls it from the root of their RAIL directory (I believe this is $RAILDIR - ie, the directory from where they'd have to call ceci examples/goldenspike_examples/goldenspike.yml to run it) for the time being, but interested in future path flexibility.