Closed drewoldag closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
f3086e8
) 100.00% compared to head (1336bc5
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
It looks like RAIL/examples/evaluation_examples/demo.ipynb https://github.com/LSSTDESC/RAIL/blob/main/examples/evaluation_examples/demo.ipynb still uses the deprecated package, can you update the references in there to point to qp rather than the old deprecated versions? I think that's the only demo that hasn't been updated.
@sschmidt23 I think that we're all updated at this point. Let me know if you notice anything else!
Yep, everything looks good and runs for me now, thanks @drewoldag , I think this is fine to be merged.
These metrics and tests were ported to qp several months ago. There don't seem to be any places where the RAIL implementations are still being used - they would have been producing deprecation warnings for months. Now they will simply fail, and we can update them as needed.