search

LSSTDESC / rail_base

Base classes for RAIL
MIT License
0 stars 1 forks source link

Noisifier uses a hardcoded seed. Selector subclasses make use of a `seed` param, but isn't defined. #103

Closed drewoldag closed 2 months ago

drewoldag commented 2 months ago

I noticed that the Noisifier has a hardcoded parameter, seed here https://github.com/LSSTDESC/rail_base/blob/main/src/rail/creation/noisifier.py#L21 which seems bad (but might be intentional)

Additionally, I noticed that InvRedshiftIncompleteness Selector makes use of seed, but seed isn't defined as a stage parameter for the Selector class. https://github.com/LSSTDESC/rail_astro_tools/blob/main/src/rail/creation/degradation/spectroscopic_degraders.py#L141 https://github.com/LSSTDESC/rail_base/blob/main/src/rail/creation/selector.py#L22-L25