LSSTDESC / rail_base

Base classes for RAIL

MIT License

0 stars 1 forks source link

Issue/124/mask summarizers #130

Closed eacharles closed 4 months ago

eacharles commented 5 months ago

Problem & Solution Description (including issue #)

Code Quality

[ ] My code follows the code style of this project
[ ] I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
[ ] My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
[ ] Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

eacharles commented 5 months ago

Still need to add tests

eacharles commented 5 months ago

124

ztq1996 commented 4 months ago

I think what is implemented is a good starting point.

One thing I want to suggest: usually when tomographic binning is provided, people want to get the n(z) for all the bins. So we probably want something that produces multiple n(z) as the default. The difficult thing about this is the data structure, since ceci wants a deterministic output path, I am thinking about creating a "nzHandle" with a list of qp ensembles as its data, does that make sense?

eacharles commented 4 months ago

I had a similar idea, The main difference was that I was thinking to just put them all in a single qp Ensemble and use the ancillary data to provide information about the bin...

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.47619% with 10 lines in your changes missing coverage. Please review.

Project coverage is 97.79%. Comparing base (284a4bd) to head (962e0ae).

Files	Patch %	Lines
src/rail/estimation/algos/naive_stack.py	90.38%	5 Missing :warning:
src/rail/estimation/algos/point_est_hist.py	89.79%	5 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #130 +/- ## ========================================== - Coverage 98.18% 97.79% -0.39% ========================================== Files 41 41 Lines 2095 2181 +86 ========================================== + Hits 2057 2133 +76 - Misses 38 48 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.