LSSTDESC / rail_base

Base classes for RAIL
MIT License
0 stars 1 forks source link

TableHandle._size returns 0 on any exception #155

Closed joezuntz closed 1 month ago

joezuntz commented 1 month ago

Currently the TableHandle._size method tries to open an HDF5 table but catches all exceptions. So if there is any error whatsoever (e.g. wrong group name) then later things go silently wrong. In conjunction with the other issue I just opened this means that you can get silent sys.exit() calls with no traceback.

I don't know what kinds of errors you're expecting to pick up here but the current catch is too broad.

eacharles commented 1 month ago

done with #158