LSSTDESC / rail_base

Base classes for RAIL
MIT License
0 stars 1 forks source link

remove logic for uneeded extra chunks #159

Open eacharles opened 2 months ago

eacharles commented 2 months ago

Problem & Solution Description (including issue #)

Code Quality

eacharles commented 2 months ago

154

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.47%. Comparing base (482235d) to head (1272d15).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #159 +/- ## ========================================== - Coverage 98.47% 98.47% -0.01% ========================================== Files 45 45 Lines 2485 2484 -1 ========================================== - Hits 2447 2446 -1 Misses 38 38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joselotl commented 2 months ago

Originally, if one of the iterators doesn't have any input data the output will complain. I used sys.exit to free the unused nodes, but I'm guessing this messes with the next stages in a pipeline. Still, I think it needs somehow to tell the unused nodes not to expect an output

eacharles commented 2 months ago

Can we catch the issue in the writing of the output?

eacharles commented 2 months ago

Let's wait and hear more from Josue about how we might solve downstream issues before we merge this one.