LSSTDESC / rail_base

Base classes for RAIL
MIT License
0 stars 1 forks source link

New config param to define point estimates to calculate when running a `CatEstimator` stage #29

Closed drewoldag closed 1 year ago

drewoldag commented 1 year ago

Work in progress

It is not yet settled whether the default should be no calculations or all calculations done on behalf of the user. However, this PR is still mostly valid regardless of the decision.

Introduce a new config parameters, calculated_point_estimates, in SHARED_PARAMS that will be used by subclasses of CatEstimator.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (39959e4) 97.53% compared to head (b5eff6d) 97.54%. Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## ======================================= Coverage 97.53% 97.54% ======================================= Files 28 28 Lines 1585 1586 +1 ======================================= + Hits 1546 1547 +1 Misses 39 39 ``` | [Files Changed](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [src/rail/core/common\_params.py](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3JhaWwvY29yZS9jb21tb25fcGFyYW1zLnB5) | `100.00% <ø> (ø)` | | | [src/rail/estimation/estimator.py](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3JhaWwvZXN0aW1hdGlvbi9lc3RpbWF0b3IucHk=) | `100.00% <100.00%> (ø)` | | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/29/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eacharles commented 1 year ago

it would make sense as a next step to add a function to the base class to actually use the new parameter.