Closed jfcrenshaw closed 1 year ago
Patch coverage has no change and project coverage change: -2.17%
:warning:
Comparison is base (
91adfec
) 97.53% compared to head (cdd18fc
) 95.37%. Report is 7 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR only removed the LSSTErrorModel
(it has been moved to rail_astro_tools
), but, because that code was all covered by tests, removing those lines of code decreased the fraction of lines in this repo covered by tests. This is blocking the merge. Is it possible for someone to override this?
Change Description
This PR addresses this ticket in
rail_astro_tools
, by moving theLSSTErrorModel
degrader to that repo, and removing the explicit error model implementation by just wrapping the error model in PhotErr.~Note these tests will fail until the associated PR the associated PR in
rail_astro_tools
with the newLSSTErrorModel
is merged.~Oops! I was wrong! I needed to remove all the
LSSTErrorModel
imports in this repo -- the tests here don't know anything aboutrail_astro_tools
.