Closed drewoldag closed 10 months ago
Patch coverage: 100.00%
and project coverage change: +0.01%
:tada:
Comparison is base (
e6b0478
) 95.56% compared to head (5a3bc45
) 95.58%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@eacharles I took another look over this after the prompt to do so at the Monday tag-up meeting, and I'm not seeing anything that needs to change at this point. Was there anything else in particular that you would like me to review prior to merging this code? If not, could I request a final re-review from you?
Change Description
This PR moved the point estimation code to a core mixin class. This will avoid duplication if/when we move to introduce a
Reducer
RAIL stage.Additionally, we call
self.calculate_point_estimates
inCatEstimator._do_chunk_output
to avoid having to make changes in all subclasses of CatEstimator. i.e. we get point estimation for free (when a user requests it) without having to modify any subclasses.Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist