Closed eacharles closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
cccd4c8
) 95.58% compared to head (f92c1d3
) 96.75%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It looks like the glob command in test_render_nb
wasn't finding anything even before this PR (i.e. much of the test is uncovered in the codecov report for the current main
branch). It doesn't look like pyproject.toml includes a dependence on pz-rail, so the glob command returns an empty list. Are there any notebooks available within rail_base to test render? Should we maybe include two very simple notebooks to render for tests (and skip one of those in the tests to test skipping?)
Thanks for the careful look. I have to confess I probably ignored the test b/c I was using the command it is supposed to test. I think a “hello world” nb in the test did is plenty. The only point is to make sure the command & option are getting to julyter correctly.On Oct 20, 2023, at 5:20 PM, Sam Schmidt @.***> wrote: It looks like the glob command in test_render_nb wasn't finding anything even before this PR (i.e. much of the test is uncovered in the codecov report for the current main branch). It doesn't look like pyproject.toml includes a dependence on pz-rail, so the glob command returns an empty list. Are there any notebooks available within rail_base to test render? Should we maybe include two very simple notebooks to render for tests (and skip one of those in the tests to test skipping?)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
Change Description
Solution Description
Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist