LSSTDESC / rail_base

Base classes for RAIL
MIT License
0 stars 1 forks source link

hook to validate date in DataHandle.set_data #54

Closed eacharles closed 10 months ago

eacharles commented 10 months ago

Change Description

Solution Description

Code Quality

Project-Specific Pull Request Checklists

Bug Fix Checklist

New Feature Checklist

Documentation Change Checklist

Build/CI Change Checklist

Other Change Checklist

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (09c542f) 96.75% compared to head (3873f48) 96.71%. Report is 2 commits behind head on main.

:exclamation: Current head 3873f48 differs from pull request most recent head d079d52. Consider uploading reports for the commit d079d52 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ========================================== - Coverage 96.75% 96.71% -0.05% ========================================== Files 32 32 Lines 1632 1642 +10 ========================================== + Hits 1579 1588 +9 - Misses 53 54 +1 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [src/rail/core/data.py](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3JhaWwvY29yZS9kYXRhLnB5) | `99.60% <90.00%> (-0.40%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eacharles commented 10 months ago

I've got to switch it to raising an exception instread of print and assert.