LSSTDESC / rail_base

Base classes for RAIL
MIT License
0 stars 1 forks source link

Updating default inputs for estimators. #59

Closed drewoldag closed 10 months ago

drewoldag commented 10 months ago

See isse #58 for details

Some of the dummy estimators are causing problems due to the change to the PZSummarizer base class here: https://github.com/LSSTDESC/rail_base/pull/49/files#diff-62873f07a43e74d27e697228918f71e83c43501335e3f403d24f0664ffdced74

For the summarizers that don't require a model as input, we should override the input values to be: input = [('input', QPHandle)]

The summarizers in this category are:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (069e09d) 97.13% compared to head (3cf1e49) 97.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ======================================= Coverage 97.13% 97.13% ======================================= Files 32 32 Lines 1673 1676 +3 ======================================= + Hits 1625 1628 +3 Misses 48 48 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [src/rail/estimation/algos/naive\_stack.py](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3JhaWwvZXN0aW1hdGlvbi9hbGdvcy9uYWl2ZV9zdGFjay5weQ==) | `100.00% <100.00%> (ø)` | | | [src/rail/estimation/algos/point\_est\_hist.py](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3JhaWwvZXN0aW1hdGlvbi9hbGdvcy9wb2ludF9lc3RfaGlzdC5weQ==) | `100.00% <100.00%> (ø)` | | | [src/rail/estimation/algos/var\_inf.py](https://app.codecov.io/gh/LSSTDESC/rail_base/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3JhaWwvZXN0aW1hdGlvbi9hbGdvcy92YXJfaW5mLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.