search

LSSTDESC / rail_base

Base classes for RAIL
MIT License
0 stars 1 forks source link

Adding base classes for creation #90

Closed ztq1996 closed 3 months ago

ztq1996 commented 4 months ago

All creation/degradation can be divided into two kinds of degradation type:

  1. add noise to the input catalog
  2. make cuts/selections

I propose to call the first one "noisifier" or "noiseAdder", and the second one "selector"

Here are the baby steps:

  1. Create noisifier.py, and a noisifier class in it. The noisifier should have function to check the length of the input and output to be the same. There should be a dummy noisifier that add no noise to it.
  2. Create selector.py, and a selector class in it.
  3. Add a deprecation warning to degrader class in the degrader.py. We won't remove degrader.py until all subclasses has finished migrating to the new parent classes.
eacharles commented 3 months ago

closed with #96