LSSTDESC / rail_lephare

RAIL wrapper to the LePHARE photometric redshift code
MIT License
1 stars 0 forks source link

Fixed model error and changed code to set run without symlink #37

Closed raphaelshirley closed 5 months ago

raphaelshirley commented 5 months ago

Closes #36

We should perhaps set the link to the run directory in a more robust way. currently I get it from the default work directory and go up a level to runs. We also might wnat to make it overwritable in the estimator so that the folder can be moved between systems

Using the symlinked $cache/lephare/work directory creates the possibility of two informers using it simultaneously and intereferring with the default location during local runs. rail_lepahre should use completely independent work directories using the informer name.

Code Quality

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.93%. Comparing base (e5c47db) to head (52ded5c). Report is 23 commits behind head on main.

Files Patch % Lines
src/rail/estimation/algos/lephare.py 72.72% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## =========================================== - Coverage 100.00% 91.93% -8.07% =========================================== Files 1 2 +1 Lines 8 124 +116 =========================================== + Hits 8 114 +106 - Misses 0 10 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.