Closed raphaelshirley closed 5 months ago
Attention: Patch coverage is 58.33333%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 49.61%. Comparing base (
8b60454
) to head (2d33944
). Report is 6 commits behind head on main.:exclamation: Current head 2d33944 differs from pull request most recent head f9d7ad0
Please upload reports for the commit f9d7ad0 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
src/rail/estimation/algos/lephare.py | 58.33% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Waiting for other PRs to merge before merging to ensure config values consistent with updated string dict format
Closes #43
I want to wait for the lephare string dict changes and the COSMOS param defaults to merged before merging to ensure merge conflicts are handled correctly
Problem & Solution Description (including issue #)
The redshift grid was being read from the lepahre config which could be distinct from the stage params and cause a confusion. WE instead overwrite the lephare config from the params. This should allow the notebook to be sped up by setting a sparse redshift grid in the inform params.
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added