Closed joezuntz closed 3 months ago
Attention: Patch coverage is 75.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 46.57%. Comparing base (
3f512c3
) to head (9769526
).
Files | Patch % | Lines |
---|---|---|
src/rail/estimation/algos/lephare.py | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi all - this is ready to review now - see my note on slack #desc-pz-rail for a plan, should not merge it yet.
Changes look fine. I will make some tests with the new code to check it all runs through our examples...
Am I allowed to merge this or should one of the owners do it?
Am I allowed to merge this or should one of the owners do it?
I didn't merge as I saw @raphaelshirley's comment on testing this with the new code. @raphaelshirley are you happy with this to be merged?
Hi yes this can be merged. Tests ran locally.
This PR updates the constructors of all stage subclasses to work with ceci version 2, in which aliases are specified in the constructor. A similar PR has been opened for each RAIL repo.
The main change is to the the constructors to accept any keywords with **kwargs and pass them to the parent class.
I have also removed any constructors which did not do anything except call the parent class constructor. Since this happens automatically if you omit the constructor, these were redundant.
Finally, in constructors I have changed I have removed hard-coded parent classes in favour of the python3 recommended super() function. If the parent class are changed in the future the constructor will still work.