search

LSSTDESC / rail_pipelines

Collection of RAIL-based data analysis pipelines
MIT License
0 stars 0 forks source link

Issue/375/introspection #12

Closed eacharles closed 1 year ago

eacharles commented 1 year ago

Sorry sam

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (c5d60d8) 98.57% compared to head (d94e011) 98.61%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #12 +/- ## ========================================== + Coverage 98.57% 98.61% +0.03% ========================================== Files 3 3 Lines 70 72 +2 Branches 3 3 ========================================== + Hits 69 71 +2 Misses 1 1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `98.61% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/LSSTDESC/rail_pipelines/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [...rail/pipelines/examples/goldenspike/goldenspike.py](https://app.codecov.io/gh/LSSTDESC/rail_pipelines/pull/12?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3JhaWwvcGlwZWxpbmVzL2V4YW1wbGVzL2dvbGRlbnNwaWtlL2dvbGRlbnNwaWtlLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

aimalz commented 1 year ago

Tagging @OliviaLynn on this comment because I know she recently dealt with an accidental duplicate of the cleanup script and might have some insight on if it was (re)moved strategically as part of the bigger reorganization of the examples directory currently under way.

Looks good, and things appear to work, only minor comment: the goldenspike.ipynb notebook has a final cell that says to just run cleanup.sh to delete all the temp files, but we did not include cleanup.sh in rail_pipelines/nb/examples/goldenspike, we could think about adding that back in here.

edit: one other comment: should we add a curl command to grab the example HSC data for the inform_all_hsc example?

(And while I'm here, re: edit, that sounds like a good idea to me!)

eacharles commented 1 year ago

The notebook is going to be moved to rail_hub in a PR coming along very soon. Let's fix these issues there, once it is in it's final place.

sschmidt23 commented 1 year ago

Ah, yes I forgot about the fact that these will move anyway, sorry, there was another earthquake at 3:30 am that woke me up so not firing on all cylinders today.