search

LSSTDESC / rail_pipelines

Collection of RAIL-based data analysis pipelines
MIT License
0 stars 0 forks source link

Update smoke-test.yml to emit failures to slack channel #27

Closed drewoldag closed 5 months ago

drewoldag commented 5 months ago

This PR adds the functionality to emit smoke test failure message to the pz-desc-rail-ci slack channel.

drewoldag commented 5 months ago

The unit tests are failing for the same reason that the smoke tests have been failing. i.e. making these updates didn't trigger these test failures :)

sschmidt23 commented 5 months ago

I approved, though I won't merge in case @hangqianjun has additional comments. Also, the test failing is obviously unrelated, I wasn't sure if we wanted to wait until the tests are once again passing (probably in a separate PR that we would have to merge into this branch) before merging.

drewoldag commented 5 months ago

I don't have a strong opinion about waiting vs. merging now. If we do merge now, then we'll start getting pings in the CI channel of course. I'll leave it up to you all to decide if that's considered annoying or helpful.