LSSTDESC / rail_pipelines

Collection of RAIL-based data analysis pipelines
MIT License
0 stars 0 forks source link

Fix goldenspike.py to use DistToPointEvalutor #29

Closed eacharles closed 5 months ago

eacharles commented 5 months ago

Problem & Solution Description (including issue #)

28

Code Quality

ztq1996 commented 5 months ago

May I propose using the new evaluator? It is used in the goldenspike notebook in rail_hub

eacharles commented 5 months ago

It looks liek we have this: for key, val in eval_dict.items(): the_eval = DistToPointEvaluator.make_stage(name='dist_to_point', force_exact=True, **evaluator_stage_dict) result_dict[key] = the_eval.evaluate(val, truth)

  1. Sure we can use that,
  2. But we should change both to have name=f'dist_topoint{key}', otherwise the output files will collide
ztq1996 commented 5 months ago

Yeah, if that works.