search

LSSTDESC / sacc

Save All Correlations and Covariances
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

qp-prob #104

Closed cmbant closed 5 months ago

cmbant commented 5 months ago

The qp module only appears to be loaded dynamically, and likely is not needed in e.g. CMB use cases. Suggest removing qp-prob from requirements? (or at least make it optional) On Windows, I can't install sacc with pip due to issue compiling pytdigest which is a requirement of qp-prob.

joezuntz commented 5 months ago

Twenty five years and you're still the only cosmologist using Windows, Antony!

But yes, making this an optional requirement makes sense. I can add an "all" installation option.

cmbant commented 5 months ago

Thanks! "tables_io" seems to be also used be loaded dynamically but not listed in requirements. There are some small typos/refactors you might want to check at https://github.com/LSSTDESC/sacc/compare/master...cmbant:sacc:master

There are other instances of unused quantity = table.meta.get('SACCQTTY', 'generic') , and probably a missing "return" in _hg_ls_files_and_dirs (if ret)?

joezuntz commented 5 months ago

Version 0.14 is now on pypi and has the both qp-prob and numpydoc as optional dependencies. You can install with sacc[all], sacc[doc], or sacc[qp].

I'm also doing a PR for your other tweaks - many thanks. Though I think _hg_ls_files_and_dirs is in the library that gets used to do the versioning, not sacc itself.