LSSTDESC / sacc

Save All Correlations and Covariances
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

sacc version 0.11 self-reports as sacc 0.9 #96

Closed marcpaterno closed 1 year ago

marcpaterno commented 1 year ago

The most recent release of sacc (0.11) reports itself to be sacc 0.9; the __init__.py file was not updated to reflect the new version number.

joezuntz commented 1 year ago

shit, sorry. Will release a version 0.12

marcpaterno commented 1 year ago

Hi Joe,

I’d be happy to fix it. Would you consider naming it 0.11.1, to help indicate there is no API difference from 0.11 ?

--Marc

From: joezuntz @.> Date: Tuesday, August 8, 2023 at 8:46 AM To: LSSTDESC/sacc @.> Cc: Marc F Paterno @.>, Assign @.> Subject: Re: [LSSTDESC/sacc] sacc version 0.11 self-reports as sacc 0.9 (Issue #96)

shit, sorry. Will release a version 0.12

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_LSSTDESC_sacc_issues_96-23issuecomment-2D1669651178&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=d3p0PLQb2ItFxNVHOOIv2tbqRE3Vbq3EtoL-OopFQXc&m=Tph4a7H66_80rw79jaTIIPyHozOTSIBiijE6kGJeeRJa81O7dhdU5lqxEliNyoPF&s=Uht1AFzJfsTGRdQ6Y-qkgUtiBsGmz1l5Mn8D0Bo-CWQ&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AABMJX3SKR2KJ3PA6PYKXKDXUI7JLANCNFSM6AAAAAA3IQGJFI&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=d3p0PLQb2ItFxNVHOOIv2tbqRE3Vbq3EtoL-OopFQXc&m=Tph4a7H66_80rw79jaTIIPyHozOTSIBiijE6kGJeeRJa81O7dhdU5lqxEliNyoPF&s=7vzwsoJVoZHeWuBTjLUKIRpNcivvqGTsEELIx5fDSj0&e=. You are receiving this because you were assigned.Message ID: @.***>

marcpaterno commented 1 year ago

Hi again,

In response to my own proposal, I found that changing the __version__ string to 0.11.1 results in a build that gets the installation artifacts labeled as 0.12 anyway. So, never mind my proposal to name it 0.11.1.

--Marc

From: joezuntz @.> Date: Tuesday, August 8, 2023 at 8:46 AM To: LSSTDESC/sacc @.> Cc: Marc F Paterno @.>, Assign @.> Subject: Re: [LSSTDESC/sacc] sacc version 0.11 self-reports as sacc 0.9 (Issue #96)

shit, sorry. Will release a version 0.12

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_LSSTDESC_sacc_issues_96-23issuecomment-2D1669651178&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=d3p0PLQb2ItFxNVHOOIv2tbqRE3Vbq3EtoL-OopFQXc&m=Tph4a7H66_80rw79jaTIIPyHozOTSIBiijE6kGJeeRJa81O7dhdU5lqxEliNyoPF&s=Uht1AFzJfsTGRdQ6Y-qkgUtiBsGmz1l5Mn8D0Bo-CWQ&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AABMJX3SKR2KJ3PA6PYKXKDXUI7JLANCNFSM6AAAAAA3IQGJFI&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=d3p0PLQb2ItFxNVHOOIv2tbqRE3Vbq3EtoL-OopFQXc&m=Tph4a7H66_80rw79jaTIIPyHozOTSIBiijE6kGJeeRJa81O7dhdU5lqxEliNyoPF&s=7vzwsoJVoZHeWuBTjLUKIRpNcivvqGTsEELIx5fDSj0&e=. You are receiving this because you were assigned.Message ID: @.***>

joezuntz commented 1 year ago

Apologies, I've set it running as v0.12 already, but I agree that would have been more sensible!

marcpaterno commented 1 year ago

This was fixed by commit 6c3aae85584beefad0f2e14194961e353269a660.