search

LSSTDESC / sims_GCRCatSimInterface

LSST sims interface to gcr-catalogs
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

U/jchiang/command line script fixes #17

Closed jchiang87 closed 6 years ago

jchiang87 commented 6 years ago

@jbkalmbach @danielsf It looks like the Sprinkler versions of the galaxy and agn classes being used in InstanceCatalogWriter are writing RA, Dec in units of radians instead of degrees to the instance catalogs. Could one of you have a look please? Might as well just put any fixes in this branch. Thanks!

danielsf commented 6 years ago

I have fixed the problem with RA, Dec.

There appears to be an additional problem with position angle. I am showing values in excess of 1000, and it is supposed to be in degrees. This problem persists, even if the sprinkler is turned off. I will continue to investigate.

danielsf commented 6 years ago

And those last two commits fix the positionAngle problem.

jchiang87 commented 6 years ago

Thanks for the fixes @danielsf . Here are plots showing the ~footprints of the object classes produced by the generateInstCat.py script with and without the sprinkler enabled for a 1deg fov centered on the dithered pointing position of visit 230 using minion_1016_desc_dithered_v4.db. The higher count yellow regions are populated by the protoDC2 galaxies, while the lower count blue regions are just the stars. The black points are my attempt to identify sprinkled SL objects by plotting entries with the same redshift as the previous entry and which have an agn SED specified. I suspect the black points in the unsprinkled plot are accidently resampled AGN as consecutive entries. I'm thinking it would be better to sample that population without replacement.

The region boundaries are from the Run 1.1 Specifications google doc. The sprinkled region appears to be a bit smaller than intended, based on that doc.

sprinkled_v230_1deg-fov unsprinkled_v230_1deg-fov

jchiang87 commented 6 years ago

I think we need to merge this before merging #19 . Unless there are objections, I'll merge it into master at 12 Noon PT, today.

jbkalmbach commented 6 years ago

Are people okay with the location of the sprinkled objects? I can add a new version of the caches if we want to get right up to the edge of the uDDF region. I left a little room on the edges on purpose just to absolutely make sure I stayed in the uDDF region.

Also, Jim I think your RA boundaries for the uDDF in the plot are a little large (I think it should only go from 52.575 - 53.675 deg) making it a little more exaggerated in that direction.

jchiang87 commented 6 years ago

I got the boundary numbers from the Run1.1 Specifications document, so if the numbers there are wrong, that document should be corrected. In any case, I'm ok with the current uDDF area for the sprinkled objects.

jbkalmbach commented 6 years ago

Oh, no, you're right, I didn't see the table when I made the boundaries, I was just using 1.1 degree square sides so I guess there is that extra amount of space. Sorry about that. But if we're good I will just leave it alone for now.

katrinheitmann commented 6 years ago

So should the document be corrected to be consistent?

On 1/31/18 11:21 AM, Bryce Kalmbach wrote:

Oh, no, you're right, I didn't see the table when I made the boundaries, I was just using 1.1 degree square sides so I guess there is that extra amount of space. Sorry about that. But if we're good I will just leave it alone for now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LSSTDESC/sims_GCRCatSimInterface/pull/17#issuecomment-362005441, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQ9jOlU_D0a9vU7z9YcBQFFLcECQe4gks5tQKETgaJpZM4RzIlf.

jchiang87 commented 6 years ago

If the fix is easy, then please go ahead and make it, but I don't think it's crucial. We have some time since we still need to look at #19.

If we don't change it, then we should update the Run1.1 spec with the as-implemented values.

jbkalmbach commented 6 years ago

@katrinheitmann Maybe we could mention that the uDDF region is also a trapezium in the second paragraph of the design section.

katrinheitmann commented 6 years ago

Please feel free to edit the document as you see fit. It's important that it describes exactly what we do :-)

On 1/31/18 11:48 AM, Bryce Kalmbach wrote:

@katrinheitmann https://github.com/katrinheitmann Maybe we could mention that the uDDF region is also a trapezium in the second paragraph of the design section.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LSSTDESC/sims_GCRCatSimInterface/pull/17#issuecomment-362013832, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQ9jI9zqS9KUPZoEQzd6ujGulleVX9Yks5tQKeAgaJpZM4RzIlf.

jchiang87 commented 6 years ago

For the record, Bryce updated the cache files for the sprinkled lens objects. Here is the updated plot of the sprinkled field:

sprinkled_v230_1deg-fov