search

LSSTDESC / sims_GCRCatSimInterface

LSST sims interface to gcr-catalogs
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

U/danielsf/ref cat2 #46

Open danielsf opened 6 years ago

danielsf commented 6 years ago

This PR will add a script to generate a reference catalog for use with DC2.

danielsf commented 6 years ago

@evevkovacs @jchiang87 I assume the name of the full yaml file will be more useful than the version number, in case we ever start generating catalogs against buzzard or some other simulation. Is there a reason I shouldn't use the name of the yaml file?

yymao commented 6 years ago

@danielsf I think we should use the name of the yaml file. The reason we want to use the alias is to avoid having to update multiple places when the catalog is updated. But you can still keep track of what catalog the alias pointed to though.

evevkovacs commented 6 years ago

@yymao @danielsf The yaml file name would work, but I guess I have a preference for using the catalog name and version as provided by the catalog metadata. This is more formal, and unambiguous. I can imagine yaml files coming and going, different abbreviations/names being used etc, whereas what's in the metadata is permanent and unchanging. Yao will probably have an opinion.

danielsf commented 6 years ago

Actually, I just found the GCRCatalogs.get_catalog_config() method. I'll just output the contents of that dict. That is probably the most detailed option.

danielsf commented 6 years ago

(this may, in fact, be what Eve was advocating, anyway)

yymao commented 6 years ago

@danielsf yes, I think keeping track of the config content is the best solution here.