search

LSSTDESC / sims_GCRCatSimInterface

LSST sims interface to gcr-catalogs
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

U/danielsf/sprinkled/truth #49

Closed danielsf closed 6 years ago

danielsf commented 6 years ago

This isn't actually a mature pull request, so much as a place where we can organize our thoughts on how to get truth information out of the sprinkler.

I have added an is_sprinkled column to the InstanceCatalogs. There is a PR into the Twinkles repo which will alter the sprinkler to set is_sprinkled=1 for any objects changed or added by the sprinkler. I have then added code to the InstanceCatalogWriter so that, for each InstanceCatalog that gets written, it will write out a truth catalog with the RA, Dec, SED, magNorm, uniqueId, and galaxy_id of objects for which is_sprinkled==1. These are just placeholder columns. We will need to talk about what we want the columns to be.

Obviously, this PR will result in many truth catalogs (one per InstanceCatalog) being written. We will have to add code elsewhere to cull these down into a single, multi-epoch truth catalog, assuming this is the strategy we want to adopt for sprinkler truth info.

danielsf commented 6 years ago

Note: I haven't been able to test this on sprinkled supernovae, because I haven't found an obsHistID that contains a sprinkled supernova. If someone knows of one of the top of their head, please let me know.

danielsf commented 6 years ago

52 supersedes this PR