Incompatibility between knots and sprinkler

LSSTDESC / sims_GCRCatSimInterface

LSST sims interface to gcr-catalogs

BSD 3-Clause "New" or "Revised" License

1 stars 5 forks source link

Incompatibility between knots and sprinkler #57

Open EiffL opened 6 years ago

EiffL commented 6 years ago

@jbkalmbach In testing the production version of sims_GCRCatSimInterface (v0.2.0) it appears that the sprinkler code bypasses the flux correction applied to the disks when a knots_addon catalog is provided, and from what I can tell just by looking at the code, I'm afraid this is still the case in master. I'll work on a fix tomorrow morning, but I'm opening an issue to track the problem.

jbkalmbach commented 6 years ago

Since we are caching the galaxy ids we are using in the sprinkler for DC2 could this be used to make sure no galaxies with knots are being used by the sprinkler?

jbkalmbach commented 6 years ago

By the way, we do have an issue related to this here: LSSTDESC/DC2-production/issues/128