Minor fix that prevents annoying crashes when the sprinkler is disabled

LSSTDESC / sims_GCRCatSimInterface

LSST sims interface to gcr-catalogs

BSD 3-Clause "New" or "Revised" License

1 stars 5 forks source link

Minor fix that prevents annoying crashes when the sprinkler is disabled #59

Closed EiffL closed 6 years ago

EiffL commented 6 years ago

In the current code, when the sprinkler is disabled, the generateInstCat.py will crash if the path to SIMS_GCRCATSIMINTERFACE_DIR/data/outputs doesn't exist, which shouldn't be a problem given that the sprinkler is disabled. This PR just fixes the path verification logic and ignores the missing path in case the sprinkler is disabled

danielsf commented 6 years ago

I know you didn't ask for my review, but this looks fine to me. Given the clock that is ticking over Run 2.0i, I say "merge it".

mpwiesner commented 6 years ago

Looks good, thanks.

EiffL commented 6 years ago

Thanks guys :-)