search

LSSTDESC / sims_GCRCatSimInterface

LSST sims interface to gcr-catalogs
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Adds instance catalog crawler #64

Closed EiffL closed 5 years ago

EiffL commented 5 years ago

@jchiang87 @danielsf Adds a script that crawl instance catalogs and dropped offensive objects, or apply last minute fixes. WIP: Not ready to merge yet ! I'm checking that it works, then will improve the code that actually opens and outputs instance catalogs.

EiffL commented 5 years ago

@rmandelb @jchiang87 @danielsf Ok, this should be final now, I'm doing some tests but it all looks good. Number of lines are preserved, randomly picked entries look the way I would expect, flux correclty preserved between knots and disks after correction

katrinheitmann commented 5 years ago

One quick question: where are you going to write those files to? Same directories as the original files are in and name them differently?

Then I would have to copy a lot of extra data since I would want to just copy full directory structures.

If the plan is to do that, then I think we should still tar also the unchanged files so that we don't have a flood of data.

Thanks!

On 9/16/18 10:29 PM, Francois Lanusse wrote:

@rmandelb https://github.com/rmandelb @jchiang87 https://github.com/jchiang87 @danielsf https://github.com/danielsf Ok, this should be final now, I'm doing some tests but it all looks good. Number of lines are preserved, randomly picked entries look the way I would expect, flux correclty preserved between knots and disks after correction

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LSSTDESC/sims_GCRCatSimInterface/pull/64#issuecomment-421883340, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQ9jL2598GQCa15GhYGM6sRzFXmjRRDks5ubxcRgaJpZM4WrD2Y.