search

LSSTDESC / sims_GCRCatSimInterface

LSST sims interface to gcr-catalogs
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

U/danielsf/cosmodc2/agn #67

Closed danielsf closed 5 years ago

danielsf commented 5 years ago

This PR includes

The old code was querying the database of AGN parameters every time a new chunk of galaxies was processed. This was very slow. The new code queries the AGN database once for all AGN, stores the result, and refers back to that result in as it loops over the chunks of galaxies.

You will note that I have not edited InstanceCatalogWriter.py to actually use this functionality (by setting _do_prefiltering=True in the AGN catalog). That is going to be included in another pull request. I implemented it on top of a bunch of other API changes I made.

yymao commented 5 years ago

@danielsf I am not sure if I am fully qualified to review this. The changes to the InstanceCatalog infrastructure look good to me, but I haven't been working on the AGN database generation part.

danielsf commented 5 years ago

Honestly, I think I am the only one who has been looking at the AGN database generation code, so, if that's your worry, I'm not sure who else I would push this off on.

I will @jchiang87 in case he wants to look at this (but I already sent him one PR today and didn't want to hit him too hard...)

Thanks, @yymao

yymao commented 5 years ago

Ah, ok, I can take a closer look in that case.

danielsf commented 5 years ago

Thanks

danielsf commented 5 years ago

Thanks, Yao. I just needed someone to have a look to make sure I wasn't totally off my rocker.