search

LSSTDESC / skyCatalogs

Create sky catalogs and provide access via API
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Improvements in SNe handling #74

Closed JoanneBogart closed 8 months ago

JoanneBogart commented 9 months ago

For sncosmo and snana objects

JoanneBogart commented 9 months ago

@jchiang87 Code to handle NaNs in the mag correction arrays have been added. This PR is ready for review.

JoanneBogart commented 8 months ago

The gaia CI test is failing because load_collection is being called with the skycatalog argument left at its default value of None, and I added code in BaseObject to use the logger instance created by instances of SkyCatalog. I don't think that should be allowed (None for skycatalog argument) but at the moment it's not being enforced. I can take that code out of BaseObject and put in SnanaObject, which is the only place it's needed currently, but I'd rather update test_gaia_objects to call load_collection with a real SkyCatalog instance (and also modify load_collection to complain when that argument is None).

JoanneBogart commented 8 months ago

I've added the warning for missing mjd to SnanaCollection.init( ) Do you think it's necessary for Sncosmo as well? For something which people are unlikely to use? It's a little more work since there is no SncosmoCollection class yet, but doable if you think it's necessary. With that possible exception all issues you raised have been addressed. Never mind. Simpler to just put it in than discuss it.

JoanneBogart commented 8 months ago

Ready for review