search

LSSTDESC / skyCatalogs

Create sky catalogs and provide access via API
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

U/jrbogart/config include #78

Closed JoanneBogart closed 8 months ago

JoanneBogart commented 9 months ago

Addresses issue #76 Allow use of include files within a config. The primary motivation and expected use is to allow the config information for an object type to be in a separate file which can be in a subdirectory of the catalog dir (where the top-level config file is) along with the data for that type. The subdirectory may be a sym link.

matroxel commented 8 months ago

Besides the two inline comments, looks like its doing what you want to me.

JoanneBogart commented 8 months ago

@matroxel thanks for taking a look. What inline comments are you referring to?

I think I forgot to officially ask for your review. I have now.

matroxel commented 8 months ago

The two directly above here, e.g. about YamlIncludeConstructor.

JoanneBogart commented 8 months ago

I'm sorry; I don't see any inline comments. Are they visible to you on this "Conversation" tab? Or if on some other page, please specify. I've adapted one of the test programs to use the include facility. The first time through all the tests ran successfully, then pytest crashed. It doesn't crash when I run locally. I've restarted the CI job. You can see example yaml files in skycatalogs/data/ci_sample. Start with skyCatalog_top.yaml