Lack of consistency in `object_names` behaviour

LSSTDESC / snmachine

Machine learning code for photometric supernova classification

BSD 3-Clause "New" or "Revised" License

9 stars 5 forks source link

Lack of consistency in `object_names` behaviour #216

Closed Catarina-Alves closed 4 years ago

Catarina-Alves commented 4 years ago

The output of dataset.object_names is different for regular PlasticcData (numpy.ndarray) and augmented PlasticcData (pandas.core.series.Series). It should be the same.

file: snaugment (?)

Catarina-Alves commented 4 years ago

It might be better to simply add a setter method in sndata because the object names is a property that is useful to change in multiple occasions

Catarina-Alves commented 4 years ago

Solved by #217