Open Catarina-Alves opened 5 years ago
This change can be gradual but once we touch a function/ class that has one of these names, we can change it to the accorded one.
Files changed to this convention:
gps_test.py
(except line 30 as it uses something from sndata
)I personally would prefer to not have numbers in variable names, so something like reduced_chi_square
is preferable to me
I personally would prefer to not have numbers in variable names, so something like
reduced_chi_square
is preferable to me
I am okay with that. It is a bit longer and it was because of that that I choose the other.
Can we close this, or does this relate to this https://github.com/LSSTDESC/snmachine/pull/122#issuecomment-493093270 ?
Over
snmachine
there are different references to the reduced X^2. I think it would be better to always call it in the same way. So far I have seen (this is not an exhaustive list):rchi2
-snfeatures
line 141rcs
-snfeatures
line 594chi2
-snfeatures
line 597 (this appears in several places and I think it is dangerous as X^2 is different from reduced X^2)redChi2
-gps
line 150reduced_chi_squared
-sndata
line 474reducedChi2
-gps
line 289I propose to call it
reduced_chi2
reduced_chi_squared
for variable name.