search

LSSTDESC / tables_io

A small package to provide tools to read / write and convert tabular data for DESC
MIT License
1 stars 1 forks source link

Issue/5/table dict #7

Closed eacharles closed 3 years ago

eacharles commented 3 years ago

I think that this is a pretty good first pass at the table IO and conversion interface. I'm sure that there are a number of things that could be improved, most notably the metadata handling and the interface for iterating over chunks of data.

I've put some temporary doc here for folks to look at: https://www.slac.stanford.edu/~echarles/temp_tables_io/html/

Please feel free to have a look & make comments and suggestions. But I think that rather than doing a full, line-by-line code review, at this point it might make more sense to agree on the main interfaces and open issues for things that we think should be added or changed.

I'd like to get a first release out soon, so that I can start converting qp and RAIL to use this.

codecov[bot] commented 3 years ago

Codecov Report

Merging #7 (5acafa8) into main (250bd3f) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main        #7    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         8     +5     
  Lines          186       488   +302     
==========================================
+ Hits           186       488   +302
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tables_io/__init__.py 100.00% <100.00%> (ø)
tables_io/arrayUtils.py 100.00% <100.00%> (ø)
tables_io/convUtils.py 100.00% <100.00%> (ø)
tables_io/ioUtils.py 100.00% <100.00%> (ø)
tables_io/lazy_modules.py 100.00% <100.00%> (ø)
tables_io/tableDict.py 100.00% <100.00%> (ø)
tables_io/testUtils.py 100.00% <100.00%> (ø)
tables_io/types.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 250bd3f...5acafa8. Read the comment docs.