search

LSSTDESC / tables_io

A small package to provide tools to read / write and convert tabular data for DESC
MIT License
1 stars 1 forks source link

Applying RAIL-specific python project template. #81

Closed drewoldag closed 11 months ago

drewoldag commented 11 months ago

This PR update the code base to use the RAIL-specific python project template. None of the functionality should have changed.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (4e55059) 100.00% compared to head (0b40410) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 636 641 +5 ========================================= + Hits 636 641 +5 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/tables_io/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [src/tables\_io/arrayUtils.py](https://app.codecov.io/gh/LSSTDESC/tables_io/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3RhYmxlc19pby9hcnJheVV0aWxzLnB5) | `100.00% <100.00%> (ø)` | | | [src/tables\_io/testUtils.py](https://app.codecov.io/gh/LSSTDESC/tables_io/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3RhYmxlc19pby90ZXN0VXRpbHMucHk=) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/LSSTDESC/tables_io/pull/81/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eacharles commented 11 months ago

So, this is somehow failing to lazy-load jax.numpy, but I can't reproduce this on my desktop, even when I try to create the conda environment from scratch.

drewoldag commented 11 months ago

Yeah, also failed to reproduce this locally with a fresh conda env.

eacharles commented 11 months ago

Ok so for some reason testing that the jax.numpy lazy load worked by doing mod.__file__ was causing a recurison loop, so I changed the test to have it do dir(mod) and split out the test.