87 add functionality to use input iterator in rail for parquet files

LSSTDESC / tables_io

A small package to provide tools to read / write and convert tabular data for DESC

MIT License

1 stars 1 forks source link

87 add functionality to use input iterator in rail for parquet files #88

Closed joselotl closed 8 months ago

joselotl commented 10 months ago

Problem & Solution Description (including issue #)

Code Quality

[ ] My code follows the code style of this project
[ ] I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
[ ] My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
[ ] Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f5fcae2) 100.00% compared to head (4076457) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #88 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 658 673 +15 ========================================= + Hits 658 673 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joselotl commented 10 months ago

I added some functions to solve bug report https://github.com/LSSTDESC/rail/issues/116 as well as https://github.com/LSSTDESC/rail_bpz/issues/42

I don't know why it is reporting a change in coverage, I added the apropiate tests to the new functions

eacharles commented 10 months ago

There were two test functions with the same name. Also added a test for an unsupported file type, should be at 100% coverage now.