Open sidneymau opened 3 months ago
Note: doing so would require dropping support for Python 3.9 (match
was added in 3.10). I'm not sure what the overall opinion about python version support is, but worth keeping in mind.
I have no idea why the github bot thought this was appropriate for Review
in the project tracker... this isn't even a PR
There is a lot of code in tables_io that uses a series of
if
statements before falling back to an error. This should probably be amatch
statement now that those are supported in python.For example, what is currently implemented as
could be rewritten as
I think this would be a bit clearer and more robust to any possible conflicts with the type enum, etc.