LSSTScienceCollaborations / StackClub

Learning the LSST software Stack, by writing jupyter notebook tutorials.
https://stackclub.readthedocs.io/
MIT License
45 stars 17 forks source link

Notebooks failing under Release 17.0 #188

Closed drphilmarshall closed 5 years ago

drphilmarshall commented 5 years ago

@LSSTScienceCollaborations/stack-club

Following this morning's discussion of checking our notesbooks with the new v17 Stack, I took Keith and David's advice and ran beavis-ci on the StackClub repo, like this:

./beavis-ci.sh LSSTScienceCollaborations/StackClub --kernel lsst

This does indeed force the use of the v17 kernel - as you can see from one of the output cells from the template notebook:

grep lsst_distrib GettingStarted/templates/template_Notebook.nbconvert.ipynb
      "lsst_distrib          17.0       \tcurrent v17_0 setup\r\n"

So, here's the beavis-ci stdout, showing the notebooks that fail to run to completion under v17.0:

WARNING: failed to produce ./Deblending/lsst_stack_deblender.nbconvert.ipynb. See /home/pjm43/notebooks/.beavis/StackClub/./Deblending/log/lsst_stack_deblender.log for details.
SUCCESS: ./Deblending/scarlet_tutorial.nbconvert.ipynb produced.
WARNING: failed to produce ./SourceDetection/LowSurfaceBrightness.nbconvert.ipynb. See /home/pjm43/notebooks/.beavis/StackClub/./SourceDetection/log/LowSurfaceBrightness.log for details.
WARNING: failed to produce ./Basics/Calexp_guided_tour.nbconvert.ipynb. See /home/pjm43/notebooks/.beavis/StackClub/./Basics/log/Calexp_guided_tour.log for details.
WARNING: failed to produce ./Basics/afw_table_guided_tour.nbconvert.ipynb. See /home/pjm43/notebooks/.beavis/StackClub/./Basics/log/afw_table_guided_tour.log for details.
SUCCESS: ./Basics/DataInventory.nbconvert.ipynb produced.
SUCCESS: ./Visualization/AFW_Display_Demo.nbconvert.ipynb produced.
SUCCESS: ./Visualization/bokeh_holoviews_datashader.nbconvert.ipynb produced.
SUCCESS: ./GettingStarted/FindingDocs.nbconvert.ipynb produced.
SUCCESS: ./GettingStarted/templates/template_Notebook.nbconvert.ipynb produced.
SUCCESS: ./GettingStarted/ImportTricks.nbconvert.ipynb produced.
SUCCESS: ./GettingStarted/HelloWorld.nbconvert.ipynb produced.
SUCCESS: ./Validation/image_quality_demo.nbconvert.ipynb produced.
WARNING: failed to produce ./ImageProcessing/BrighterFatterCorrection.nbconvert.ipynb. See /home/pjm43/notebooks/.beavis/StackClub/./ImageProcessing/log/BrighterFatterCorrection.log for details.
WARNING: failed to produce ./ImageProcessing/Re-RunHSC.nbconvert.ipynb. See /home/pjm43/notebooks/.beavis/StackClub/./ImageProcessing/log/Re-RunHSC.log for details.
WARNING: failed to produce ./ImageProcessing/ProcessEimage.nbconvert.ipynb. See /home/pjm43/notebooks/.beavis/StackClub/./ImageProcessing/log/ProcessEimage.log for details.

Unfortunately the git push seems not to have worked, so the badges on our README.rst pages are not up to date - I'll try again. In the meantime, please take a look to see whether the tutorials that you own need attention!

kadrlica commented 5 years ago

@drphilmarshall how are we doing on this issue? Can we close it in favor of #204?

kadrlica commented 5 years ago

This has been superseded by #204