LSSTScienceCollaborations / StackClub

Learning the LSST software Stack, by writing jupyter notebook tutorials.
https://stackclub.readthedocs.io/
MIT License
45 stars 17 forks source link

Minor typos in Footprints.ipynb #191

Closed kadrlica closed 3 years ago

kadrlica commented 5 years ago

A great notebook! This issue is just to track a few typos that I probably introduced.

  1. Minor typo
    im = plt.imshow(fps[0].getSpans().unflatten(hfps[0].getMaskArray()),
                origin='lower')

    should be hfps[0].getSpans.

  2. "The footprint of the parent object contains catalog of the peaks it contains." -> "The footprint of the parent object contains a catalog of the peaks associated with the parent."
kadrlica commented 5 years ago

Robert suggests

def footprintToImage(fp, mi=None, mask=False):
    bb = fp.getBBox()
    im = afwImage.MaskedImageF(bb)
    fp.insert(im)
    return im

im = footprintToImage(hfps[0])

disp = afwDisplay.Display(backend="matplotlib")
disp.mtv(im)