search

LSSTScienceCollaborations / StackClub

Learning the LSST software Stack, by writing jupyter notebook tutorials.
https://stackclub.readthedocs.io/
MIT License
45 stars 17 forks source link

Verify LSB notebook on v18.0.0 #205

Closed kadrlica closed 5 years ago

kadrlica commented 5 years ago

This is a trivial update to verify that this notebook runs on v18.0.0.

kadrlica commented 5 years ago

@DouglasLeeTucker would you be willing to review this easy PR?

DouglasLeeTucker commented 5 years ago

Yep, would be happy to do so!

But it looks like GitHub is having some issues this morning (see attached GitHub status page). I will try again later today.

Thanks!

Best regards, Douglas

--

Douglas L. Tucker Fermilab Tel: +1-630-840-2267 MS 127 FAX: +1-630-840-8274 PO Box 500 E-mail: dtucker@fnal.gov Batavia, IL 60510 USA http://home.fnal.gov/~dtucker/

From: Alex Drlica-Wagner notifications@github.com Reply-To: LSSTScienceCollaborations/StackClub reply@reply.github.com Date: Sunday, July 21, 2019 at 10:36 AM To: LSSTScienceCollaborations/StackClub StackClub@noreply.github.com Cc: Douglas L Tucker dtucker@fnal.gov, Mention mention@noreply.github.com Subject: Re: [LSSTScienceCollaborations/StackClub] Verify LSB notebook on v18.0.0 (#205)

@DouglasLeeTuckerhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_DouglasLeeTucker&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=R-57Mm7OJX1IswbY4ezVTQ&m=myVBaQ7TNyiVs9olZE-6fmGj1t7c4tM7R3H6shSGYtw&s=3GG0-2m4zEzjXb3X_mvnFb1oX8PL7caRNE7zwmEI2MU&e= would you be willing to review this easy PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_LSSTScienceCollaborations_StackClub_pull_205-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAARAHOP64X7IFXL6NVWEYTDQAR67PA5CNFSM4IFSWAHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2OF65Q-23issuecomment-2D513564534&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=R-57Mm7OJX1IswbY4ezVTQ&m=myVBaQ7TNyiVs9olZE-6fmGj1t7c4tM7R3H6shSGYtw&s=1IgeuxBhliFGuucMPGcYYr5BHDQBzzSfG8DNf2MSVJg&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AARAHON6HMRWT76OIF2W4Y3QAR67PANCNFSM4IFSWAHA&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=R-57Mm7OJX1IswbY4ezVTQ&m=myVBaQ7TNyiVs9olZE-6fmGj1t7c4tM7R3H6shSGYtw&s=N-0Uw3lfqXqdZ9Uw1GxljS27GlLG6DzhS4yzLTI54U8&e=.

kadrlica commented 5 years ago

@DouglasLeeTucker just checking on the status of this. I'd like to get this PR merged before the LSST PCW next week.

Thanks! Alex

DouglasLeeTucker commented 5 years ago

Sorry for the delay, @kadrlica ! I'll work on it this afternoon. Thanks!

kadrlica commented 5 years ago

Thanks @DouglasLeeTucker!