search

LSSTScienceCollaborations / StackClub

Learning the LSST software Stack, by writing jupyter notebook tutorials.
https://stackclub.readthedocs.io/
MIT License
45 stars 17 forks source link

Ihasan/footprints v20 #240

Closed ih64 closed 4 years ago

ih64 commented 4 years ago

this PR updates the Footprints.ipynb so it works for v20 of the LSST Pipelines

kadrlica commented 4 years ago

@ih64 did you commit the compiled notebook by accident? Maybe a rebase is needed to roll back this commit.

kadrlica commented 4 years ago

Or alternatively, close this PR and make a new one without the compiled commit?

ih64 commented 4 years ago

whoops, sorry about that @kadrlica , my mistake. I added another commit clearing out the output. When I go to 'Files Changed' it looks like the un-compiled version is there now.

kadrlica commented 4 years ago

Thanks @ih64. I think the issue is that the previous commit is still in the PR, so it would be merged into the tree with this PR. The concern is that the rendered PNGs will bloat the repo size. While we aren't strict about this, I was thinking that we'd want a new PR with just the uncompiled version. I can give this a shot tonight and ask you to review it.

kadrlica commented 4 years ago

Closing this to open a new PR with the clean notebook.