search

LSTS / dune

DUNE: Unified Navigation Environment
Other
111 stars 120 forks source link

C++11 as standard #114

Closed krisklau closed 5 years ago

krisklau commented 6 years ago

Hi,

I was wondering if there has been any discussion about using C++11 as default for DUNE? We have been using it internally for a while, and several of the features are really useful when working with DUNE.

Kristian

rasmartins commented 6 years ago

It's definitely something that I've been ruminating in the last few months. From the developer point of view it's a no-brainer. However, since we (OceanScan) have a lot of systems in the field with C++98 only compilers it would be a major effort for us to upgrade those systems in order for them to run new DUNE versions. With that being said, I'm inclined to take the leap to C++14 one of these days.

krisklau commented 6 years ago

That makes sense, and thank you for the reply.

In the meantime, would be it an option to somehow enable this on a task-specific basis? Or the other way around, disable tasks if C++14 is not available for the compiler? This would make it possible to use the legacy compilers for most of the tasks.

I'l close this for now as I mainly wanted your input, keep us posted.

krisklau commented 6 years ago

Reopened to hear the status of this.

rasmartins commented 6 years ago

I gave LSTS access to OceanScan-MST codebase which already sets the required C++ standard to C++-14. We are using gcc 4.9 for production which supports C++-11 and some C++-14 features.

On Wed, Aug 29, 2018 at 12:37 PM Kristian Klausen notifications@github.com wrote:

Reopened to hear the status of this.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LSTS/dune/issues/114#issuecomment-416921463, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTFhE2FLR1oOlwESefipvFwChkijiYzks5uVnzngaJpZM4R1Q1B .

zepinto commented 5 years ago

Now using CPP14 (master).