Closed mvanputgrccontrol closed 1 week ago
Thank you so much for the positive feedback and the code review! I really appreciate you taking the time to look through the project. I'm thrilled you see the potential in Aegis!
Your suggestions are excellent and align with my vision of making Aegis even more powerful and flexible.
I've already started brainstorming how to incorporate:
Microsoft.FeatureManagement.AspNetCore
. Mapping Aegis features to a feature manager would be a seamless way to enable or disable functionality based on licenses, but I am hesitant to use it as main features manager or keep the default implementation and integrate it using separated package aka Aegis.Microsoft.FeatureManagement
.builder.AddAegisServer(...)
approach as it provides nice extensibility. The dotnet new
template is also a great idea for quickly scaffolding a new Aegis.Server project but I have no experience for creating .net templates and it's less flexible to build a whole project and some new unknown codebase rather than using it as just addition.I'm very open to contributions and discussions! Would you be interested in collaborating on any of these features? It would be fantastic to have your input as we work on enhancing Aegis.
Thanks again for your support!
I'm happy to collaborate for those features.
Regarding the integration with other libraries, I totally agree with your comments. My idea also is to create extension packages for example Microsoft.FeatureManagement
. However this is a nice to have for long term.
For the other ones, the Aegis Server library is the best step to start.
Do you have any contribution guidelines? We can also connect on slack or something.
I don't have a specific contribution guidelines yet.
well, it's always good to have plans for long term, and I agree that the server library is the best to start with.
for Aegis Server library I planned to strip out all asp.net dependencies and just embed the LicenseService
and HeartbeatMonitorService
and make the developers inherit their DbContext
on top of Aegis DbContext
to have all necessary tables, and let them create their own controllers and auth services and provide the endpoints to the core library, any suggestions on that are welcome.
And I would like to connect, although I usually use FB or reddit only, they aren't teams targeted, I compared slack and discord and I found that discord is more feature rich than slack, if you were open to connect on discord I would be happy, my username is _lsxprime
and we got a server at Discord
Since we decided to discuss these suggestions at the Discord server and this issue is stale for the past 3 weeks, I am gonna close it for now, and since it's not an actual issue I will move it to discussions.
Thank you for creating, building and publishing this library. It looks really nice! Will test the functionality later on. I'm currently using my custom library for licensing our product.
The feedback I have (also based on requirements I face(d)) based on code review.
Microsoft.FeatureManagement.AspNetCore
(or other feature management libraries). Feature flags can be loaded in to theIFeatureManager
. Same applies for rate limit support.builder.AddAegisServer(..)
for example. This allows you to update the server logic and integrate with oidc authorization etc. Another solution would be to create adotnet new template
for this.Keep up the good work. I'm happy to contribute and discuss to this project!