search

LTCHIPS / rottexpr

A Rise Of The Triad Source Port with additional gameplay options and more...
GNU General Public License v2.0
97 stars 26 forks source link

Removing old obsolete controllers code #7

Closed ghost closed 6 years ago

ghost commented 6 years ago

Clearing up a lot of things, and not messing up with the menus.

Even though every thing seems to be correct on my side, please review the code carefully before integration.

LTCHIPS commented 6 years ago

Fine by me, most of the Spaceball, Assassin and Cyberman code had been removed from the icculus port anyways, so there wasn't much sense in keeping them...

Don't forget to remove the menu entries too!

ghost commented 6 years ago

Yes, I took care of the menu entries too. Thanksfully, I've done it cleanly without any bugs.

Last time I did that, I don't remember which mistake I've made, but the menu was behaving very incorrectly (wrong offset when redrawing text lines and logo, menu rotating twice when exitting the controller pannel).

So I'm glad to see everything works out!

LTCHIPS commented 6 years ago

I'm not experiencing that on my end, was it on any of the menus I might've made? Those are...

visual options (and all of its sub menus too)

ext game options

On Tue, Jun 12, 2018 at 3:13 AM, Marc-Alexandre Espiaut < notifications@github.com> wrote:

Yes, I took care of the menu entries too. Thanksfully, I've done it cleanly without any bugs.

Last time I did that, I don't remember which mistake I've made, but the menu was behaving very incorrectly (wrong offset when redrawing text lines and logo, menu rotating twice when exitting the controller pannel).

So I'm glad to see everything works out!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/LTCHIPS/rottexpr/pull/7#issuecomment-396489380, or mute the thread https://github.com/notifications/unsubscribe-auth/AQSOHAbhvisObKBKRM53Qp7CL7JZEXdcks5t72oAgaJpZM4UjS_x .

-- Thanks, Steven LeVesque