search

LTH14 / rcg

PyTorch implementation of RCG https://arxiv.org/abs/2312.03701
MIT License
785 stars 36 forks source link

About crossattn in RDM #5

Closed umnooob closed 8 months ago

umnooob commented 8 months ago

Thanks for your impressive work!

I notice that in the config and comments, crossattn is used for context to condition input. However, simply addition op is used in ResBlock. Any performance differences between them?

And it would be nice if you could provide the original crossattn implementation.

LTH14 commented 8 months ago

Thanks for your interest! I directly modify LDM's code for RDM, so there might be some legacy issues (crossattn is one of them). To clarify, cross-attention is not used in RDM. We only use simple addition when incorporating conditioning.

umnooob commented 8 months ago

Thanks for your reply!