search

LTHTR-DST / hdruk_avoidable_admissions

HDRUK Data Science Collaboration on Avoidable Admissions in the NHS.
https://lthtr-dst.github.io/hdruk_avoidable_admissions/
MIT License
6 stars 5 forks source link

Snomed codes validation #20

Closed ccarenzoIC closed 1 year ago

ccarenzoIC commented 1 year ago

Hi, I have a question regarding the validate.py script:

I've seen that some fields like edchiefcomplaint don't get an "isin" validation, referencing the values from nhsdd_snomed, why is this?

Thanks!

vvcb commented 1 year ago

Thanks for taking the time to dig into this. The emergency care dataset validation logic has not been completed yet. Quin and I will find some time this week to do this.

Happy to take contributions. If you are familiar with git workflow, then please fork, clone your fork of this repo, develop and create a pull request. Alternatively, happy to have code snippets as responses to issues.

vvcb commented 1 year ago

@ccarenzoIC - Does your PR #21 address this? If it does, can we close this issue? Let me know if there is more to do.

@quindavies, can we test this #21 on the LTH ED dataset please?

MattStammers commented 1 year ago

When do we get the next release 🥇 :octocat:

vvcb commented 1 year ago

@ccarenzoIC , please see https://github.com/LTHTR-DST/hdruk_avoidable_admissions/pull/21#issuecomment-1421571369 and let me know what you think.

@MattStammers, will aim 0.2.0 with ED data pipeline tomorrow after conferring with @ccarenzoIC and @quindavies. We want to test this against LTH data before tagging it as a release.

vvcb commented 1 year ago

A number of challenges remain with SNOMED code validation - see #27 as well.

vvcb commented 1 year ago

Closing as multiple PRs have addressed this. Some challenges remain but none that can be readily solved through this libary.