search

LTLA / bluster

Clone of the Bioconductor repository for the bluster package.
https://bioconductor.org/packages/devel/bioc/html/bluster.html
2 stars 3 forks source link

Dmm param creation #16

Closed BananaCancer closed 1 year ago

BananaCancer commented 1 year ago

Here is the PR to add the DMM algorithm to bluster, as discussed in #15 as well as in the microbiome/bluster PR. I changed the DirichletMultinomial dependency so feel free to tell me if there's anything else to change.

LTLA commented 1 year ago

Good start. Just a few minor things to fix.

BananaCancer commented 1 year ago

I updated the examples, is there anything else to change?

LTLA commented 1 year ago

I think it looks fine, I'll run through some checks tomorrow morning just to be sure.

BananaCancer commented 1 year ago

By the way, should I push the files in src/* ? I'm not used to do that, but since it's not in the gitignore, I'm not sure whether I should do it or not.

LTLA commented 1 year ago

Can you give me push access to this PR? There are a few clean-ups that I want to apply before merging.

BananaCancer commented 1 year ago

Should be working, tell me if not.

LTLA commented 1 year ago

Alright, pushed to BioC-devel as 1.11.3. Thanks for the contribution.

FWIW you should be able to enable maintainer push access without giving me write access to your fork. I think there's an option on the PR itself to allow the host maintainer to add commits to the PR'ing branch.