search

LTLA / scuttle

Clone of the Bioconductor repository for the scuttle package.
https://bioconductor.org/packages/devel/bioc/html/scuttle.html
9 stars 7 forks source link

Size factors allowed to be zero even when positive=TRUE #9

Closed alanocallaghan closed 3 years ago

alanocallaghan commented 3 years ago

Unless you're making a bold mathematical claim, I think zero is unsigned

https://github.com/LTLA/scuttle/blob/acbe47592c4252bc88beaf9500abc7948d0b80ac/R/pooledSizeFactors.R#L353

LTLA commented 3 years ago

grumble I suppose.