search

LTTLabsOSS / markbench-tests

Home of test harnesses used in LTT Labs MarkBench
GNU General Public License v3.0
634 stars 28 forks source link

[Suggestion] get_app_install_location may return empty erroneously #44

Open rcmaehl opened 9 months ago

rcmaehl commented 9 months ago

Environment

- MarkBench Test Version: Latest
- OS: N/A
- GPU: N/A
- CPU: N/A

What happened?

For various reasons, including importing an existing steam library, Uninstall entries for steam apps may not be written to registry. This may cause get_app_install_location to return empty erroneously

A better flow would be the following:

  1. Get Steam Install location from "\Software\Valve\Steam\SteamPath"
  2. Get Library Folders and their apps from SteamPath + "\steamapps\libraryfolders.vdf"

I am not great with python but I can attempt to make a pull request if wanted.

Relevant log output

No response

Anything else?

No response

rcmaehl commented 9 months ago

It does look like @AutonomicPerfectionist fixes this in #13. I will contribute to that PR